Region as certificate authority, BMC power drivers, IPv6
CA (llmgw-style) - region creates its CA (ECDSA P-256) and serves API/UI/images over HTTPS on tls_listen with a certificate for every name/address it has (reissued on change or a month before expiry); admin_http policy (allow|loopback|deny) for the admin API over plain HTTP; /ca.pem - rack controllers enroll with one-time join codes (CA fingerprint + secret + expiry + address): rollcall controller join-code, rollcall rack join; mutual TLS from then on, identity from the certificate (CN rack:NAME, serial on record), removal revokes, renewal a month before expiry; the shared rack_secret stays as a legacy fallback - clients: CA from the server config, ROLLCALL_CA, or trusted on first connect in the console after showing the fingerprint (kept in client.json); deployed machines trust it via cloud-init ca_certs (allowed on RHEL-family images), overlays get .CA; rollcall ca show|issue Power drivers - ipmi (cipher/privilege/interface), redfish (system discovery, ResetType from AllowableValues or ActionInfo, boot override with If-Match), idrac, ilo, supermicro, xcc, openbmc, proxmox (API token), manual; executed on the rack controller; Redfish auto-detection after commissioning; operator settings survive recommissioning; rollcall bmc, BMC editing in web UI and console - lab: pve_redfish.py Redfish emulator per Proxmox VM (iDRAC, iLO, generic profiles) IPv6 - IPv6 subnets and IPAM (netip), dual-stack default layout (all subnets of the boot VLAN), per-family default routes, accept-ra off where addresses are planned, dnsmasq RA/DHCPv6 with router lifetime 0 unless the rack is the gateway, AAAA host records from IPAM, IPv6 listen addresses and URLs, rack interfaces and region certificate with IPv6, agent reports IPv6 Tests for CA/join/pinning/CSR signing, Redfish (iDRAC, iLO fallbacks, probe), Proxmox, manual, IPv6 candidates, dual-stack plans and dnsmasq IPv6. Verified in the lab: rack2 enrolled and running on mutual TLS only, revocation and single-use codes; iLO auto-detected through rack2, iDRAC and Proxmox drivers, wrong password not saved; Debian 13 (bond+VLAN), Rocky 9 and AlmaLinux 9 dual-stack with Redfish-driven deployments; CA trusted on Debian and AlmaLinux; admin CLI over HTTPS on IPv4 and IPv6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
736a7e38a3
commit
c8465c235a
29 files changed
+3156
-241
No files matched your search
+84
-6
@@ -3,6 +3,8 @@ package main
|
||||
import (
|
||||
"context"
|
||||
"crypto/subtle"
|
||||
"crypto/tls"
|
||||
"crypto/x509"
|
||||
"embed"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
@@ -10,7 +12,9 @@ import (
|
||||
"io"
|
||||
"io/fs"
|
||||
"log"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/url"
|
||||
"regexp"
|
||||
"strings"
|
||||
"sync"
|
||||
@@ -25,6 +29,7 @@ type App struct {
|
||||
store *Store
|
||||
sealer *Sealer
|
||||
hub *rackHub
|
||||
ca *CA
|
||||
|
||||
netMu sync.RWMutex
|
||||
racks map[string]RackController
|
||||
@@ -59,8 +64,29 @@ func (a *App) isAdmin(r *http.Request) bool {
|
||||
return strings.HasPrefix(h, "Bearer ") && tokenEqual(strings.TrimPrefix(h, "Bearer "), a.cfg.AdminToken)
|
||||
}
|
||||
|
||||
// adminOverHTTP applies admin_http to requests that did not come over TLS.
|
||||
func (a *App) adminOverHTTP(r *http.Request) error {
|
||||
if r.TLS != nil || a.cfg.AdminHTTP == "allow" {
|
||||
return nil
|
||||
}
|
||||
host, _, _ := net.SplitHostPort(r.RemoteAddr)
|
||||
if ip := net.ParseIP(host); a.cfg.AdminHTTP == "loopback" && ip != nil && ip.IsLoopback() {
|
||||
return nil
|
||||
}
|
||||
_, port, _ := net.SplitHostPort(a.cfg.TLSListen)
|
||||
h := r.Host
|
||||
if hh, _, err := net.SplitHostPort(h); err == nil {
|
||||
h = hh
|
||||
}
|
||||
return fmt.Errorf("the admin API is HTTPS-only here: https://%s (trust the CA from /ca.pem)", net.JoinHostPort(strings.Trim(h, "[]"), port))
|
||||
}
|
||||
|
||||
func (a *App) adminAuth(next http.HandlerFunc) http.HandlerFunc {
|
||||
return func(w http.ResponseWriter, r *http.Request) {
|
||||
if err := a.adminOverHTTP(r); err != nil {
|
||||
fail(w, 403, err)
|
||||
return
|
||||
}
|
||||
if !a.isAdmin(r) {
|
||||
w.Header().Set("WWW-Authenticate", `Bearer realm="rollcall"`)
|
||||
fail(w, http.StatusUnauthorized, errors.New("admin token required"))
|
||||
@@ -111,6 +137,9 @@ func (a *App) routes() http.Handler {
|
||||
mux.HandleFunc("GET /api/v1/machines/{id}/power", a.adminAuth(a.handlePower))
|
||||
mux.HandleFunc("POST /api/v1/machines/{id}/power", a.adminAuth(a.handlePower))
|
||||
mux.HandleFunc("POST /api/v1/machines/{id}/bootdev", a.adminAuth(a.handleBootdev))
|
||||
mux.HandleFunc("GET /api/v1/machines/{id}/bmc", a.adminAuth(a.handleBMC))
|
||||
mux.HandleFunc("POST /api/v1/machines/{id}/bmc", a.adminAuth(a.handleBMC))
|
||||
mux.HandleFunc("GET /api/v1/power-drivers", a.adminAuth(func(w http.ResponseWriter, r *http.Request) { writeJSON(w, 200, powerDrivers) }))
|
||||
mux.HandleFunc("GET /api/v1/whoami", a.adminAuth(func(w http.ResponseWriter, r *http.Request) {
|
||||
writeJSON(w, 200, map[string]any{"ok": true})
|
||||
}))
|
||||
@@ -173,6 +202,10 @@ func (a *App) routes() http.Handler {
|
||||
mux.HandleFunc("GET /api/v1/controllers", a.adminAuth(a.handleControllers))
|
||||
mux.HandleFunc("DELETE /api/v1/controllers/{name}", a.adminAuth(a.handleControllerDelete))
|
||||
mux.HandleFunc("GET /api/v1/controllers/{name}/dhcp", a.adminAuth(a.handleRackDHCP))
|
||||
mux.HandleFunc("GET /ca.pem", a.handleCAPEM)
|
||||
mux.HandleFunc("POST /api/v1/controllers/join", a.adminAuth(a.handleJoinCode))
|
||||
mux.HandleFunc("POST /api/v1/rack/enroll", a.handleRackEnroll) // join-code secret inside, TLS only
|
||||
mux.HandleFunc("POST /api/v1/rack/renew", a.rackAuth(a.handleRackRenew))
|
||||
mux.HandleFunc("POST /api/v1/rack/register", a.rackAuth(a.handleRackRegister))
|
||||
mux.HandleFunc("GET /api/v1/rack/state", a.rackAuth(a.handleRackState))
|
||||
mux.HandleFunc("GET /api/v1/rack/work", a.rackAuth(a.handleRackWork))
|
||||
@@ -327,7 +360,11 @@ func summarize(m *Machine) Summary {
|
||||
if m.BMC != nil {
|
||||
var b obj
|
||||
if json.Unmarshal(m.BMC, &b) == nil {
|
||||
s.BMC = &obj{"source": b["source"], "address": b["address"], "user": b["user"],
|
||||
drv := str(b["driver"])
|
||||
if drv == "" {
|
||||
drv = "ipmi"
|
||||
}
|
||||
s.BMC = &obj{"source": b["source"], "address": b["address"], "user": b["user"], "driver": drv,
|
||||
"configured": b["configured"], "verified_oob": b["verified_oob"]}
|
||||
}
|
||||
}
|
||||
@@ -429,6 +466,21 @@ func (a *App) handleCommission(w http.ResponseWriter, r *http.Request) {
|
||||
}
|
||||
m.Inventory, _ = json.Marshal(inv)
|
||||
|
||||
// a BMC an operator configured (driver_set) survives commissioning; what the agent
|
||||
// found is kept next to it for reference
|
||||
if old, err := a.store.Get(r.Context(), m.ID); err == nil && old.BMC != nil {
|
||||
var ob obj
|
||||
if json.Unmarshal(old.BMC, &ob) == nil && ob["driver_set"] == true {
|
||||
var found obj
|
||||
_ = json.Unmarshal(m.BMC, &found)
|
||||
delete(found, "password")
|
||||
ob["commissioning"] = found
|
||||
m.BMC, _ = json.Marshal(ob)
|
||||
secret = old.bmcSecret
|
||||
detail += " (operator BMC settings kept)"
|
||||
}
|
||||
}
|
||||
|
||||
isNew, err := a.store.UpsertCommissioned(r.Context(), m, secret)
|
||||
if err != nil {
|
||||
fail(w, 500, err)
|
||||
@@ -436,6 +488,9 @@ func (a *App) handleCommission(w http.ResponseWriter, r *http.Request) {
|
||||
}
|
||||
_ = a.store.AddEvent(r.Context(), m.ID, "commissioned", detail)
|
||||
_ = a.store.SetRackController(r.Context(), m.ID, a.fromRack(r))
|
||||
if full, err := a.store.Get(r.Context(), m.ID); err == nil {
|
||||
go a.probeBMC(full)
|
||||
}
|
||||
if full, err := a.store.Get(r.Context(), m.ID); err == nil {
|
||||
m = full // carries profile / node token when this is a re-commission of a stateless node
|
||||
}
|
||||
@@ -558,12 +613,11 @@ func (a *App) handlePower(w http.ResponseWriter, r *http.Request) {
|
||||
}
|
||||
action = req.Action
|
||||
}
|
||||
args, ok := powerActions[action]
|
||||
if !ok {
|
||||
if !powerOps[action] || action == "bootdev" || action == "probe" {
|
||||
fail(w, 400, fmt.Errorf("unknown power action %q", action))
|
||||
return
|
||||
}
|
||||
out, err := a.bmc(r.Context(), m, args...)
|
||||
out, err := a.power(r.Context(), m, action, "")
|
||||
if errors.Is(err, errNoBMC) {
|
||||
fail(w, 409, err)
|
||||
return
|
||||
@@ -587,7 +641,7 @@ func (a *App) handleBootdev(w http.ResponseWriter, r *http.Request) {
|
||||
fail(w, 400, fmt.Errorf("device must be one of pxe, disk, cdrom, bios, none, safe"))
|
||||
return
|
||||
}
|
||||
out, err := a.bmc(r.Context(), m, "chassis", "bootdev", req.Device)
|
||||
out, err := a.power(r.Context(), m, "bootdev", req.Device)
|
||||
if errors.Is(err, errNoBMC) {
|
||||
fail(w, 409, err)
|
||||
return
|
||||
@@ -612,13 +666,37 @@ func serve(cfgPath string) error {
|
||||
return fmt.Errorf("database: %w", err)
|
||||
}
|
||||
app := &App{cfg: cfg, store: store, sealer: sealer, hub: newRackHub()}
|
||||
if app.ca, err = loadOrCreateCA(cfg.CADir, "rollcall CA"); err != nil {
|
||||
return fmt.Errorf("certificate authority: %w", err)
|
||||
}
|
||||
ctx2, cancel2 := context.WithTimeout(context.Background(), 30*time.Second)
|
||||
err = app.startRacks(ctx2)
|
||||
cancel2()
|
||||
if err != nil {
|
||||
return fmt.Errorf("rack controllers: %w", err)
|
||||
}
|
||||
srv := &http.Server{Addr: cfg.Listen, Handler: app.routes(), ReadHeaderTimeout: 10 * time.Second}
|
||||
handler := app.routes()
|
||||
if cfg.TLSListen != "" {
|
||||
names := append([]string{}, cfg.TLSNames...)
|
||||
if u, err := url.Parse(cfg.ServerURL); err == nil && u.Hostname() != "" {
|
||||
names = append(names, u.Hostname())
|
||||
}
|
||||
pair, err := regionCert(app.ca, cfg.CADir, names)
|
||||
if err != nil {
|
||||
return fmt.Errorf("region certificate: %w", err)
|
||||
}
|
||||
pool := x509.NewCertPool()
|
||||
pool.AddCert(app.ca.Cert)
|
||||
tsrv := &http.Server{Addr: cfg.TLSListen, Handler: handler, ReadHeaderTimeout: 10 * time.Second,
|
||||
TLSConfig: &tls.Config{MinVersion: tls.VersionTLS12, Certificates: []tls.Certificate{pair}, ClientCAs: pool, ClientAuth: tls.VerifyClientCertIfGiven}}
|
||||
go func() {
|
||||
log.Printf("rollcall HTTPS on %s (CA %s)", cfg.TLSListen, app.ca.Fingerprint())
|
||||
if err := tsrv.ListenAndServeTLS("", ""); err != nil {
|
||||
log.Printf("HTTPS listener: %v", err)
|
||||
}
|
||||
}()
|
||||
}
|
||||
srv := &http.Server{Addr: cfg.Listen, Handler: handler, ReadHeaderTimeout: 10 * time.Second}
|
||||
log.Printf("rollcall listening on %s (image=%s tftp=%s agent_token=%v)", cfg.Listen, cfg.ImageDir, cfg.TFTPRoot, cfg.AgentToken != "")
|
||||
return srv.ListenAndServe()
|
||||
}
|
||||
Reference in new issue
Block a user