CI / test (push) Failing after 7m17s
From review. A mirror set already on the node is looked at again, not trusted for having been fetched once; Pickled cuts a query or a fragment from any source, hf: too; .pt2 is a pickle. The flag check reads a flag as the engine does: underscores as dashes and any beginning of a refused flag as that flag, since argparse takes --trust-remote for --trust-remote-code; SGLang refuses --load-format, which would undo the agent's safetensors. TripoSR's preset says allow_pickle: without it the preset could not be added and the presets pass failed on it each time. A shared ComfyUI environment's hidden entry takes its first member's allow_pickle, as it takes its source. The GenAI trace attributes made temperature and top_p typed fields of the request's parse, so "0.7" as a string was a 400; they are read loosely, as they are read only for the trace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
45 lines
1.4 KiB
Go
45 lines
1.4 KiB
Go
package engines
|
|
|
|
import (
|
|
"slices"
|
|
"testing"
|
|
)
|
|
|
|
func TestAModelDownloadedByTheEngineIsReadAsSafetensorsOnly(t *testing.T) {
|
|
for path, want := range map[string]bool{
|
|
"Qwen/Qwen2.5-7B-Instruct": true,
|
|
"/var/lib/llmgw/weights/abc/": false, "./local": false,
|
|
"http://m/q/v/": false, "q.gguf": false,
|
|
} {
|
|
got := slices.Contains(safetensorsOnly(Profile{ModelPath: path}), "safetensors")
|
|
if got != want {
|
|
t.Errorf("%q: safetensors only = %v, want %v", path, got, want)
|
|
}
|
|
}
|
|
if len(safetensorsOnly(Profile{ModelPath: "Qwen/Qwen2.5-7B-Instruct", AllowPickle: true})) != 0 {
|
|
t.Error("allow_pickle still forced safetensors")
|
|
}
|
|
}
|
|
|
|
func TestAForbiddenFlagIsKnownHoweverItIsSpelled(t *testing.T) {
|
|
for engine, args := range map[string][]string{
|
|
"vllm": {"--trust_remote_code"},
|
|
"sglang": {"--load-format", "pt"},
|
|
} {
|
|
if UnsafeArgs(engine, args) == nil {
|
|
t.Errorf("%s %v was let through", engine, args)
|
|
}
|
|
}
|
|
for _, a := range [][]string{{"--load_format", "pt"}, {"--trust-remote"}, {"--load-form=pt"}} {
|
|
if UnsafeArgs("vllm", a) == nil {
|
|
t.Errorf("vllm %v was let through", a)
|
|
}
|
|
}
|
|
// What is not one of them, nor the start of one, still passes.
|
|
for _, a := range [][]string{{"--max-model-len", "8192"}, {"--tokenizer-mode", "mistral"}, {"--gpu-memory-utilization=0.9"}} {
|
|
if err := UnsafeArgs("vllm", a); err != nil {
|
|
t.Errorf("vllm %v was refused: %v", a, err)
|
|
}
|
|
}
|
|
}
|