A model whose profiles run engine comfyui is placed on a node's card like any other, and makes pictures there. ComfyUI asks for no key, so the agent starts it behind llmgw comfyui-gate: ComfyUI on the loopback, the gate on the replica's port demanding the replica's key and letting through only what the router asks — queueing, waiting, fetching, cancelling. The gate answers the agent's /health and /v1/models, shows ComfyUI the fetched weights by their own names, and gives each replica its own base directory. ComfyUI runs as the gate's child, so its card memory is the replica's. A node offers the engine when agent.yaml names its ComfyUI (engines.comfyui.dir). The model's comfyui: block names the workflow and, for a source that is a set of files, the checkpoint. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
67 lines
2.5 KiB
Go
67 lines
2.5 KiB
Go
package engines
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestComfyUIRunsBehindTheGateWithItsKeyOutOfSight(t *testing.T) {
|
|
c := &ComfyUI{cfg: ComfyUIConfig{Dir: "/opt/comfyui"}}
|
|
cmds, err := c.Commands(ShardSpec{
|
|
ReplicaID: "r-flux-1", HTTPPort: 8100, BindAddr: "10.0.0.147", APIKey: "sekret", GPUIndices: []int{0},
|
|
Profile: Profile{Name: "p", Engine: "comfyui", ModelPath: "/w/flux.safetensors", ServedModelName: "flux",
|
|
Args: []string{"--disable-smart-memory"}},
|
|
})
|
|
if err != nil || len(cmds) != 1 {
|
|
t.Fatalf("%v %v", cmds, err)
|
|
}
|
|
args := strings.Join(cmds[0].Args, " ")
|
|
for _, want := range []string{"comfyui-gate", "--listen 10.0.0.147:8100", "--model flux", "--weights /w/flux.safetensors",
|
|
"--state comfyui/r-flux-1", "--python /opt/comfyui/.venv/bin/python", "--comfyui /opt/comfyui", "-- --disable-smart-memory"} {
|
|
if !strings.Contains(args, want) {
|
|
t.Errorf("%q not in %q", want, args)
|
|
}
|
|
}
|
|
if strings.Contains(args, "sekret") {
|
|
t.Error("the key is on the command line, where every user can read it")
|
|
}
|
|
if !slices.Contains(cmds[0].Env, "LLMGW_ENGINE_KEY=sekret") || !slices.Contains(cmds[0].Env, "CUDA_VISIBLE_DEVICES=0") {
|
|
t.Error("the key or the card is not in the environment")
|
|
}
|
|
}
|
|
|
|
func TestComfyUIRunsOnOneCard(t *testing.T) {
|
|
c := &ComfyUI{}
|
|
if err := c.Validate(Profile{Name: "p", ModelPath: "/w", TP: 2}, h100(2)); err == nil {
|
|
t.Error("a two-card ComfyUI profile was accepted")
|
|
}
|
|
if err := c.Validate(Profile{Name: "p", ModelPath: "/w", TP: 1}, h100(1)); err != nil {
|
|
t.Error(err)
|
|
}
|
|
if _, err := c.Commands(ShardSpec{Profile: Profile{ModelPath: "/w"}}); err == nil {
|
|
t.Error("commands without a ComfyUI directory")
|
|
}
|
|
}
|
|
|
|
func TestComfyUIIsOfferedByTheVersionItsBuildWrote(t *testing.T) {
|
|
dir := t.TempDir()
|
|
c := &ComfyUI{cfg: ComfyUIConfig{Dir: dir}}
|
|
if _, err := c.Probe(t.Context()); err == nil {
|
|
t.Error("a directory without main.py passed for ComfyUI")
|
|
}
|
|
_ = os.WriteFile(filepath.Join(dir, "main.py"), nil, 0o644)
|
|
_ = os.WriteFile(filepath.Join(dir, "comfyui_version.py"), []byte("__version__ = \"0.39.2\"\n"), 0o644)
|
|
if v, err := c.Probe(t.Context()); err != nil || v != "0.39.2" {
|
|
t.Errorf("%q %v", v, err)
|
|
}
|
|
if got := NewRegistry(Config{ComfyUI: ComfyUIConfig{Dir: dir}}).ProbeConfigured(t.Context()); got["comfyui"] != "0.39.2" {
|
|
t.Errorf("a configured ComfyUI is reported as %v", got)
|
|
}
|
|
if err := UnsafeArgs("comfyui", []string{"--enable-manager"}); err == nil {
|
|
t.Error("a profile may install ComfyUI nodes")
|
|
}
|
|
}
|