CI / test (push) Failing after 7m24s
With slurm.users llmgw, each project is a Slurm account, its organization's and team's above it, with the project's members and its team's and organization's on it; slurm.conf holds a job to its user's accounts. The controller's agent keeps them with sacctmgr, only what it made, and reports the jobs that ended in the last day; the leader records each once, its GPU-hours (core-hours without cards) priced at auth.gpu_hour_cost into its project's usage as model slurm/PARTITION. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
84 lines
3.3 KiB
Go
84 lines
3.3 KiB
Go
package slurmnode
|
|
|
|
import (
|
|
"context"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
|
|
llmgwv1 "gitea.mynodes.xyz/ilker/llmgw/api/gen/llmgw/v1"
|
|
"gitea.mynodes.xyz/ilker/llmgw/internal/slurm"
|
|
)
|
|
|
|
func TestAccountsMadeAndTakenAwayOnlyIfLlmgwsOwn(t *testing.T) {
|
|
h := newFake()
|
|
k := New(h, nil, "/var/lib/llmgw-agent/slurm", nil)
|
|
assoc := "sacctmgr " + strings.Join(slurm.AssocFormat, " ")
|
|
// root, and an account a Slurm administrator made.
|
|
h.outputs[assoc] = "root||\nroot|root|\nphysics||root\n"
|
|
m := &llmgwv1.Slurm{ManageAccounts: true, Accounts: []*llmgwv1.SlurmAccount{
|
|
{Name: "test", Parent: "root"}, {Name: "test-arge", Parent: "test"},
|
|
{Name: "test-arge-deneme", Parent: "test-arge", Users: []string{"ada", "ayse"}},
|
|
}}
|
|
if err := k.accounts(context.Background(), m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, want := range []string{"sacctmgr -i add account test parent=root description=llmgw",
|
|
"sacctmgr -i add account test-arge-deneme parent=test-arge description=llmgw",
|
|
"sacctmgr -i add user ayse account=test-arge-deneme"} {
|
|
if !slices.Contains(h.ran, want) {
|
|
t.Errorf("did not run %q:\n%s", want, strings.Join(h.ran, "\n"))
|
|
}
|
|
}
|
|
if !strings.Contains(string(h.files[k.accountsMarker()]), "user ada test-arge-deneme") {
|
|
t.Errorf("marker %q", h.files[k.accountsMarker()])
|
|
}
|
|
|
|
// Now there; ayse leaves the project, and the team goes.
|
|
h.outputs[assoc] = "root||\nphysics||root\ntest||root\ntest-arge||test\ntest-arge-deneme||test-arge\n" +
|
|
"test-arge-deneme|ada|test-arge\ntest-arge-deneme|ayse|test-arge\n"
|
|
h.ran = nil
|
|
m.Accounts = []*llmgwv1.SlurmAccount{{Name: "test", Parent: "root"}}
|
|
if err := k.accounts(context.Background(), m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Neither has another account: they go from the accounting.
|
|
want := []string{"sacctmgr -i remove user ayse", "sacctmgr -i remove user ada",
|
|
"sacctmgr -i remove account test-arge-deneme", "sacctmgr -i remove account test-arge"}
|
|
var got []string
|
|
for _, c := range h.ran {
|
|
if strings.Contains(c, "remove") || strings.Contains(c, " add ") {
|
|
got = append(got, c)
|
|
}
|
|
}
|
|
if !slices.Equal(got, want) {
|
|
t.Errorf("ran:\n%s\nwant:\n%s", strings.Join(got, "\n"), strings.Join(want, "\n"))
|
|
}
|
|
if slices.ContainsFunc(h.ran, func(c string) bool { return strings.Contains(c, "physics") }) {
|
|
t.Error("touched an account llmgw did not make")
|
|
}
|
|
|
|
// One still on another account: that one is made the default first.
|
|
h.outputs[assoc] = "root||\nphysics||root\nphysics|ada|\ntest||root\nx||test\nx|ada|\n"
|
|
h.files[k.accountsMarker()] = []byte("account test\naccount x\nuser ada x\n")
|
|
h.ran = nil
|
|
m.Accounts = []*llmgwv1.SlurmAccount{{Name: "test", Parent: "root"}}
|
|
if err := k.accounts(context.Background(), m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if i, j := slices.Index(h.ran, "sacctmgr -i modify user ada set defaultaccount=physics"),
|
|
slices.Index(h.ran, "sacctmgr -i remove user ada account=x"); i < 0 || j < i {
|
|
t.Errorf("ran:\n%s", strings.Join(h.ran, "\n"))
|
|
}
|
|
|
|
// Off: what llmgw made goes.
|
|
h.outputs[assoc] = "root||\nphysics||root\ntest||root\n"
|
|
h.ran = nil
|
|
if err := k.accounts(context.Background(), &llmgwv1.Slurm{}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !slices.Contains(h.ran, "sacctmgr -i remove account test") || h.files[k.accountsMarker()] != nil {
|
|
t.Errorf("not taken away:\n%s", strings.Join(h.ran, "\n"))
|
|
}
|
|
}
|