Ilker ManapandClaude Opus 5.5
97dc49cbeb
Checked on the live cluster: from any node, the mirror's management API on :8082 answered — list, fetch, delete — with no credentials. Unset --api-allow meant anyone. It now means this machine only; the control plane is let in with --api-allow, which `server init` already wrote for the mirrors it sets up, or by mutual TLS. A fetch went to whatever URL it was given, and the file server on :8081 then handed the result to anyone: "fetch http://169.254.169.254/..." read a cloud's instance metadata through the mirror, and a URL on the LAN read whatever answered there. Downloads started through the API now go to http and https only, and are refused at dial time — after resolution, on every redirect — when the address is loopback, private, link-local, CGNAT or multicast. --allow-private-sources lets them through for a mirror that really does copy from a server on its own network. `llmgw mirror add`, run by someone on the mirror itself, is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
40 lines
1.3 KiB
Go
40 lines
1.3 KiB
Go
package cli
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/netip"
|
|
"testing"
|
|
)
|
|
|
|
func TestTheMirrorAPIAnswersOnlyThisMachineUnlessTold(t *testing.T) {
|
|
ok := http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {})
|
|
call := func(h http.Handler, from string) int {
|
|
r := httptest.NewRequest("DELETE", "/v1/models/m/v", nil)
|
|
r.RemoteAddr = from + ":5000"
|
|
w := httptest.NewRecorder()
|
|
h.ServeHTTP(w, r)
|
|
return w.Code
|
|
}
|
|
cp := []netip.Prefix{netip.MustParsePrefix("10.0.0.140/32")}
|
|
|
|
// Nothing allowed and no TLS used to mean anyone: every node could delete
|
|
// models.
|
|
if got := call(apiGate(false, nil, ok), "10.0.0.141"); got != http.StatusForbidden {
|
|
t.Errorf("a node reached an unconfigured mirror API: %d", got)
|
|
}
|
|
if got := call(apiGate(false, nil, ok), "127.0.0.1"); got != http.StatusOK {
|
|
t.Errorf("the mirror's own machine was refused: %d", got)
|
|
}
|
|
if got := call(apiGate(false, cp, ok), "10.0.0.140"); got != http.StatusOK {
|
|
t.Errorf("the allowed control plane was refused: %d", got)
|
|
}
|
|
if got := call(apiGate(false, cp, ok), "10.0.0.141"); got != http.StatusForbidden {
|
|
t.Errorf("a node outside the allowlist got through: %d", got)
|
|
}
|
|
// With mutual TLS the certificate decides.
|
|
if got := call(apiGate(true, nil, ok), "10.0.0.141"); got != http.StatusOK {
|
|
t.Errorf("mTLS without an allowlist refused a client: %d", got)
|
|
}
|
|
}
|