Ilker ManapandClaude Opus 5.5
9853936e0b
Engines listen on every address their node has, with no key. Checked on the live cluster: from a neighbouring node, a request straight to an engine's port was answered — past the gateway's authentication, quotas and accounting, by anyone who could reach the node. Each replica's engine is now started with a key and refuses requests without it. The key is derived from the replica id with an HMAC over a secret kept in the store, rather than stored per replica: the router has to send the right key to replicas this process never started — adopted after a restart, or placed by the other control plane — and a function of a shared secret gives that without a table to keep in step. A key taken from one node opens that replica only. The secret is made on first use and copied with the rest of the store when moving to PostgreSQL; a new one would lock the router out of every running engine at the moment of the move. The key reaches llama.cpp and vLLM through their environment (LLAMA_API_KEY, VLLM_API_KEY) rather than their command line, which every user on the node can read; SGLang only takes it as an argument. The agent's readiness check, the router's proxy and its metrics scrape send it, the client's own Authorization still never reaches the engine, and `ctl bench` fetches the key of the replica it is pointed at from the admin API. Engines started before this keep running without a key until their replica is next started. With no store there is nowhere to keep the secret, and engines start without one, with a warning. Also formats two files that went in unformatted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
26 lines
603 B
Go
26 lines
603 B
Go
package store
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestAClusterSecretIsMadeOnceAndKept(t *testing.T) {
|
|
db, err := Open(t.Context(), filepath.Join(t.TempDir(), "s.db"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer db.Close()
|
|
a, err := db.ClusterSecret(t.Context(), "engine-key")
|
|
if err != nil || len(a) != 64 {
|
|
t.Fatalf("%q %v", a, err)
|
|
}
|
|
b, err := db.ClusterSecret(t.Context(), "engine-key")
|
|
if err != nil || a != b {
|
|
t.Errorf("a second read made a new secret: %q then %q", a, b)
|
|
}
|
|
if c, _ := db.ClusterSecret(t.Context(), "other"); c == a {
|
|
t.Error("two names share a secret")
|
|
}
|
|
}
|