ilkerandClaude Opus 5
6a13e3dddf
CI / test (push) Successful in 45s
Everything here works without GPUs and is covered by tests. The control plane connection is not built yet, so llmgw agent itself is still a stub and the phase exit criterion is not met. - discovery: IB from /sys/class/infiniband, parsing the formats sysfs actually uses and telling native InfiniBand from RoCE; GPUs via nvidia-smi, the cgo-free path, with health flags for uncorrected ECC and memory already held by another process. A node without IB is not an error, it is a single-node island. - engines: vLLM and SGLang command and environment construction, kept free of process handling so it stays testable. The NCCL environment is the part the plan marks critical: NCCL_IB_HCA lists only the chosen fabric's adapters, because leaving it open lets NCCL pick an adapter on a fabric where the peer is unreachable, and the job then hangs instead of failing. - validation before launch: no mixed GPU types in a tensor-parallel group, the node/GPU/TP arithmetic has to add up, and fp8 is refused below compute capability 8.9 rather than silently falling back to a slower path. - supervisor: process groups, because engines fork workers that hold GPU memory and outlive a signal sent only to the leader; a bounded log tail, since engine output is the only diagnosis when loading fails; Starting separate from Loading, because a 70B model legitimately takes minutes; and orphan adoption through pid files fingerprinted with the command line, since pids get reused and adopting an unrelated process is worse than leaking the original. - readiness is two questions: /health says the process is up, /v1/models says the weights loaded. Routing on /health alone sends traffic into a loading model. - llmgw agent inventory reports what the scheduler would see on a node. One plan correction: GPU class sizes come from the driver in GiB, which does not always match the marketing name. An L40S is sold as 48GB and reports 44.99 GiB, so its class is l40s-45g, not l40s-48g. Consistency matters more than matching the box, because that number decides whether a model fits. Plan §2 and §5.1 updated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
58 lines
1.1 KiB
Go
58 lines
1.1 KiB
Go
package supervisor
|
|
|
|
import "sync"
|
|
|
|
// ringBuffer keeps the last n lines of output.
|
|
//
|
|
// Engine logs are the only diagnosis available when a shard fails to load, but
|
|
// they are also unbounded — a model loading for ten minutes can produce
|
|
// megabytes. Keeping a bounded tail makes `ctl logs` useful without letting a
|
|
// chatty engine consume the agent's memory.
|
|
type ringBuffer struct {
|
|
mu sync.Mutex
|
|
lines []string
|
|
next int
|
|
full bool
|
|
}
|
|
|
|
func newRingBuffer(n int) *ringBuffer {
|
|
if n <= 0 {
|
|
n = 256
|
|
}
|
|
return &ringBuffer{lines: make([]string, n)}
|
|
}
|
|
|
|
func (r *ringBuffer) add(line string) {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
r.lines[r.next] = line
|
|
r.next = (r.next + 1) % len(r.lines)
|
|
if r.next == 0 {
|
|
r.full = true
|
|
}
|
|
}
|
|
|
|
// tail returns up to n most recent lines, oldest first.
|
|
func (r *ringBuffer) tail(n int) []string {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
size := r.next
|
|
if r.full {
|
|
size = len(r.lines)
|
|
}
|
|
if n <= 0 || n > size {
|
|
n = size
|
|
}
|
|
|
|
out := make([]string, 0, n)
|
|
for i := size - n; i < size; i++ {
|
|
idx := i
|
|
if r.full {
|
|
idx = (r.next + i) % len(r.lines)
|
|
}
|
|
out = append(out, r.lines[idx])
|
|
}
|
|
return out
|
|
}
|