Pickles refused however they come; a string temperature passes again
CI / test (push) Failing after 7m17s
CI / test (push) Failing after 7m17s
From review. A mirror set already on the node is looked at again, not trusted for having been fetched once; Pickled cuts a query or a fragment from any source, hf: too; .pt2 is a pickle. The flag check reads a flag as the engine does: underscores as dashes and any beginning of a refused flag as that flag, since argparse takes --trust-remote for --trust-remote-code; SGLang refuses --load-format, which would undo the agent's safetensors. TripoSR's preset says allow_pickle: without it the preset could not be added and the presets pass failed on it each time. A shared ComfyUI environment's hidden entry takes its first member's allow_pickle, as it takes its source. The GenAI trace attributes made temperature and top_p typed fields of the request's parse, so "0.7" as a string was a 400; they are read loosely, as they are read only for the trace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
44451bacd9
commit
fd94265e08
12 files changed
+124
-10
No files matched your search
@@ -28,3 +28,13 @@ func TestAModelInAPickleFormatIsRefusedUnlessItSaysSo(t *testing.T) {
|
||||
t.Errorf("a GGUF was refused: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestTheTripoSRPresetSaysItsCheckpointIsAllowed(t *testing.T) {
|
||||
p, ok := PresetNamed("triposr")
|
||||
if !ok {
|
||||
t.Fatal("no triposr preset")
|
||||
}
|
||||
if err := p.Model.CheckPickle(); err != nil {
|
||||
t.Errorf("the preset llmgw ships is refused by its own check: %v", err)
|
||||
}
|
||||
}
|
||||
@@ -52,6 +52,9 @@ func Presets() []Preset {
|
||||
Name: "triposr",
|
||||
Description: "TripoSR: a 3D model (GLB) from a picture of one object on a plain background, as a job",
|
||||
Source: "hf:stabilityai/TripoSR/model.ckpt",
|
||||
// TripoSR is published as this checkpoint only; it is
|
||||
// Stability AI's, pinned, and the one pickle llmgw ships.
|
||||
AllowPickle: true,
|
||||
ComfyUI: &ComfyUI{
|
||||
Workflow: "triposr",
|
||||
Output: OutputMeshes,
|
||||
|
||||
@@ -99,6 +99,7 @@ func envModel(env Environment, members []Model) Model {
|
||||
Role: RoleEnvironment,
|
||||
Description: "the shared ComfyUI replica of environment " + env.Name,
|
||||
Source: first.Source,
|
||||
AllowPickle: first.AllowPickle,
|
||||
ComfyUI: &ComfyUI{Environment: env.Name, Nodes: env.Nodes, Output: OutputEnvironment},
|
||||
Profiles: profs,
|
||||
Scaling: Scaling{Min: minN, Max: maxN, IdleTimeout: idle},
|
||||
|
||||
Reference in new issue
Block a user