A gateway serving nine models offered nine names and nothing to choose between them. /v1/models is the only view most clients ever have, and it listed ids. Models carry a description now: written when the model is added, shown on the dashboard and sent to clients in /v1/models. Written rather than derived. A registry offers a pipeline tag and a wall of README, and neither answers the question somebody picking from a list is asking — which of these should I send this request to. "General chat, strong Swedish; slower than the 8B" is not in any metadata field. It is optional, and absent means absent rather than an empty string in the response: a model nobody described should read as undescribed, not as described with nothing. On the dashboard it sits under its row rather than in a column. A sentence in a table cell either wraps every other column into a stripe or gets cut off. Co-Authored-By: Claude Opus 5 (1M context) <moreply@anthropic.com>
This commit is contained in:
1 parent
e0ea4f6be9
commit
d998ea7ef5
8 files changed
+86
-11
No files matched your search
@@ -295,3 +295,32 @@ func TestAnEstimateIsNotMadeWhenTheSizeIsUnknown(t *testing.T) {
|
||||
t.Errorf("an unknown size should leave no figure; got %s", body)
|
||||
}
|
||||
}
|
||||
|
||||
func TestADescriptionReachesTheCatalog(t *testing.T) {
|
||||
cat := &fakeCatalog{}
|
||||
mirrorPost(t, servePage(t, nil, cat, 0), "/admin/mirror/serve", url.Values{
|
||||
"csrf": {"tok"}, "name": {"coder"}, "source": {"http://x/m.gguf"},
|
||||
"engine": {"llamacpp"}, "replicas": {"1"}, "context_length": {"4096"},
|
||||
"description": {"code completion and review; 7B, fits the large node"},
|
||||
})
|
||||
|
||||
if len(cat.added) != 1 {
|
||||
t.Fatalf("expected one model, got %d", len(cat.added))
|
||||
}
|
||||
// The line a client sees in /v1/models, which for most of them is the only
|
||||
// view of what this gateway serves.
|
||||
if cat.added[0].Description != "code completion and review; 7B, fits the large node" {
|
||||
t.Errorf("the description was lost: %q", cat.added[0].Description)
|
||||
}
|
||||
}
|
||||
|
||||
func TestAModelWithNoDescriptionIsStillAccepted(t *testing.T) {
|
||||
cat := &fakeCatalog{}
|
||||
mirrorPost(t, servePage(t, nil, cat, 0), "/admin/mirror/serve", url.Values{
|
||||
"csrf": {"tok"}, "name": {"coder"}, "source": {"http://x/m.gguf"},
|
||||
"engine": {"llamacpp"}, "replicas": {"1"}, "context_length": {"4096"},
|
||||
})
|
||||
if len(cat.added) != 1 || cat.added[0].Description != "" {
|
||||
t.Errorf("a description is optional: %+v", cat.added)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user