/admin/mirror, behind the same admin session as the other admin pages. What is held, what is arriving with its byte count, what failed and why; start a fetch, retry a failed one, remove a version. Not mounted at all without a mirror configured. The right page for a deployment with no mirror is no page, rather than an empty one pointing at nothing. It reloads itself only while something is downloading. A reload at any other moment takes with it whatever is half-typed into the fetch form, and there is nothing to watch when nothing is moving. A failed row offers Retry, not Remove. A fetch that failed left nothing on disk, so the remove could only answer "the mirror holds nothing for this" — a button whose single outcome is a confusing error. Starting the same download again is what somebody looking at that row wants, and the mirror allows it: only a download still running is refused. An unreachable mirror is said outright instead of rendering as an empty table. The two look nearly identical and mean opposite things: one is a mirror waiting to be filled, the other is a machine to go and look at. Dashboard takes NavExtras rather than a second bool. Two adjacent booleans at a call site get swapped silently and are discovered by somebody clicking the wrong link. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
744a283cf1
commit
cd7eedf09e
17 files changed
+889
-24
No files matched your search
@@ -28,6 +28,8 @@ type adminUsersData struct {
|
||||
CSRF string
|
||||
Version string
|
||||
Now string
|
||||
// HasMirror keeps the nav from offering a page that was never mounted.
|
||||
HasMirror bool
|
||||
}
|
||||
|
||||
// RegisterAdminUsers mounts account administration under /admin/users.
|
||||
@@ -139,9 +141,10 @@ func (p *AccountPages) renderUsers(w http.ResponseWriter, r *http.Request,
|
||||
) {
|
||||
d := adminUsersData{
|
||||
Message: msg, Error: errMsg,
|
||||
CSRF: csrfFor(r),
|
||||
Version: p.version,
|
||||
Now: time.Now().UTC().Format(time.RFC3339),
|
||||
CSRF: csrfFor(r),
|
||||
Version: p.version,
|
||||
HasMirror: p.hasMirror,
|
||||
Now: time.Now().UTC().Format(time.RFC3339),
|
||||
}
|
||||
|
||||
all, err := s.Users(r.Context(), "")
|
||||
|
||||
Reference in new issue
Block a user