SQLite creates its file with the process umask, which on a stock system means every account on the machine can read it. What is in there is not a working credential — keys are stored hashed — but it is the whole tenancy tree and every request anyone made, and that should not depend on an operator remembering to chmod it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
1839832b8b
commit
cd3233ffe8
2 files changed
+43
No files matched your search
@@ -6,6 +6,7 @@ import (
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"slices"
|
||||
"strings"
|
||||
"time"
|
||||
@@ -44,6 +45,17 @@ func OpenSQLite(ctx context.Context, path string) (*SQLite, error) {
|
||||
_ = db.Close()
|
||||
return nil, err
|
||||
}
|
||||
// SQLite creates the file with the process umask, which on a stock system
|
||||
// means world-readable. What is in here is not a working credential — keys
|
||||
// are stored hashed — but it is the whole tenancy tree and every request
|
||||
// anyone made, and that should not be readable by every account on the
|
||||
// machine because nobody remembered to chmod it.
|
||||
for _, f := range []string{path, path + "-wal", path + "-shm"} {
|
||||
if err := os.Chmod(f, 0o600); err != nil && !os.IsNotExist(err) {
|
||||
_ = db.Close()
|
||||
return nil, fmt.Errorf("securing %s: %w", f, err)
|
||||
}
|
||||
}
|
||||
return &SQLite{db: db}, nil
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user