The page explained the API, said keys come from an operator, and left the reader there. Someone who reaches the address without a key had no route to getting one, which is where onboarding stopped. `landing.contact` is that route, because the gateway cannot guess who to ask. An address becomes a mailto link, an http(s) URL stays a link, and anything else — a channel, a queue, a person — is shown as text. Other schemes are never linked: this string comes from configuration, configuration is not always written by whoever runs the gateway, and a javascript: href on a page served to every visitor is a short path to a stored XSS. Escaping the text does not make a scheme safe. Unconfigured, it now says something rather than nothing, and the page explains that a key arrives as a one-time link so the reader knows what to expect before it lands. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
3ed211b2f4
commit
8d35faf6f8
10 files changed
+210
-14
No files matched your search
@@ -24,7 +24,7 @@ func get(t *testing.T, h http.Handler, target string, headers map[string]string)
|
||||
}
|
||||
|
||||
func TestLandingPageTellsYouHowToConnect(t *testing.T) {
|
||||
code, body := get(t, Landing("v1.2.3", true), "http://llmgw.example/", nil)
|
||||
code, body := get(t, Landing("v1.2.3", true, "", ""), "http://llmgw.example/", nil)
|
||||
if code != http.StatusOK {
|
||||
t.Fatalf("status %d", code)
|
||||
}
|
||||
@@ -38,7 +38,7 @@ func TestLandingPageTellsYouHowToConnect(t *testing.T) {
|
||||
func TestLandingPageSaysNothingAboutWhatIsHere(t *testing.T) {
|
||||
// It is served without a key, to anyone who can reach the address. Anything
|
||||
// on it is public, so nothing about the cluster belongs on it.
|
||||
_, body := get(t, Landing("v1", true), "http://llmgw.example/", nil)
|
||||
_, body := get(t, Landing("v1", true, "", ""), "http://llmgw.example/", nil)
|
||||
for _, leak := range []string{"llama", "qwen", "10.0.0.", "replica", "node01"} {
|
||||
if strings.Contains(strings.ToLower(body), leak) {
|
||||
t.Errorf("the landing page leaks %q", leak)
|
||||
@@ -49,11 +49,11 @@ func TestLandingPageSaysNothingAboutWhatIsHere(t *testing.T) {
|
||||
func TestLandingPageWarnsWhenTheGatewayIsOpen(t *testing.T) {
|
||||
// Someone who reaches this page on an unauthenticated gateway should learn
|
||||
// that from the page rather than by discovering they can use it.
|
||||
_, open := get(t, Landing("v1", false), "http://llmgw.example/", nil)
|
||||
_, open := get(t, Landing("v1", false, "", ""), "http://llmgw.example/", nil)
|
||||
if !strings.Contains(open, "no API keys configured") {
|
||||
t.Error("an open gateway does not say so")
|
||||
}
|
||||
_, closed := get(t, Landing("v1", true), "http://llmgw.example/", nil)
|
||||
_, closed := get(t, Landing("v1", true, "", ""), "http://llmgw.example/", nil)
|
||||
if strings.Contains(closed, "no API keys configured") {
|
||||
t.Error("a closed gateway claims to be open")
|
||||
}
|
||||
@@ -63,7 +63,7 @@ func TestTheExampleURLSurvivesAReverseProxy(t *testing.T) {
|
||||
// The process sees http and an internal host; the client used https and a
|
||||
// public name. An example naming the internal address is one nobody can
|
||||
// paste anywhere.
|
||||
_, body := get(t, Landing("v1", true), "http://10.0.0.140:8080/", map[string]string{
|
||||
_, body := get(t, Landing("v1", true, "", ""), "http://10.0.0.140:8080/", map[string]string{
|
||||
"X-Forwarded-Proto": "https",
|
||||
"X-Forwarded-Host": "llmgw.mynodes.xyz",
|
||||
})
|
||||
@@ -77,7 +77,7 @@ func TestTheExampleURLSurvivesAReverseProxy(t *testing.T) {
|
||||
|
||||
func TestForwardedHeaderChainsTakeTheFirstEntry(t *testing.T) {
|
||||
// A chain of proxies appends rather than replaces.
|
||||
_, body := get(t, Landing("v1", true), "http://internal/", map[string]string{
|
||||
_, body := get(t, Landing("v1", true, "", ""), "http://internal/", map[string]string{
|
||||
"X-Forwarded-Proto": "https, http",
|
||||
"X-Forwarded-Host": "llmgw.example, internal",
|
||||
})
|
||||
@@ -89,7 +89,7 @@ func TestForwardedHeaderChainsTakeTheFirstEntry(t *testing.T) {
|
||||
func TestOnlyTheRootIsTheLandingPage(t *testing.T) {
|
||||
// A catch-all would turn every mistyped path into this page, hiding real
|
||||
// 404s from anyone debugging a client.
|
||||
code, _ := get(t, Landing("v1", true), "http://x/v1/chat/completionz", nil)
|
||||
code, _ := get(t, Landing("v1", true, "", ""), "http://x/v1/chat/completionz", nil)
|
||||
if code != http.StatusNotFound {
|
||||
t.Errorf("a mistyped path returned %d", code)
|
||||
}
|
||||
@@ -231,3 +231,79 @@ func TestStaticIsNotAFileServer(t *testing.T) {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestTheLandingPageSaysWhereToGetAKey(t *testing.T) {
|
||||
// A page that explains the API and leaves the reader with no route to using
|
||||
// it is where onboarding stops.
|
||||
_, body := get(t, Landing("v1", true, "platform@example.com", ""), "http://x/", nil)
|
||||
if !strings.Contains(body, `href="mailto:platform@example.com"`) {
|
||||
t.Error("an address was not turned into a mailto link")
|
||||
}
|
||||
if !strings.Contains(body, "one-time link") {
|
||||
t.Error("the page does not say how a key will arrive")
|
||||
}
|
||||
}
|
||||
|
||||
func TestContactRenderingByKind(t *testing.T) {
|
||||
cases := []struct{ in, text, href string }{
|
||||
{"platform@example.com", "platform@example.com", "mailto:platform@example.com"},
|
||||
{"mailto:ops@example.com", "mailto:ops@example.com", "mailto:ops@example.com"},
|
||||
{"https://wiki.example/llmgw", "https://wiki.example/llmgw", "https://wiki.example/llmgw"},
|
||||
{"http://wiki.example", "http://wiki.example", "http://wiki.example"},
|
||||
// Not addresses and not URLs: shown, not linked.
|
||||
{"#platform on Slack", "#platform on Slack", ""},
|
||||
{"Ayse", "Ayse", ""},
|
||||
{"", "", ""},
|
||||
{" ", "", ""},
|
||||
}
|
||||
for _, c := range cases {
|
||||
text, href := contactLink(c.in)
|
||||
if text != c.text || href != c.href {
|
||||
t.Errorf("contactLink(%q) = (%q, %q), want (%q, %q)", c.in, text, href, c.text, c.href)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestADangerousContactSchemeIsNeverLinked(t *testing.T) {
|
||||
// This string comes from configuration, and configuration is not always
|
||||
// written by whoever runs the gateway. A javascript: href on a page served
|
||||
// to every visitor is a stored XSS with a very short path to it; escaping
|
||||
// the text does not make the scheme safe.
|
||||
for _, bad := range []string{
|
||||
"javascript:alert(1)",
|
||||
"JavaScript:alert(1)",
|
||||
"data:text/html,<script>alert(1)</script>",
|
||||
"vbscript:msgbox(1)",
|
||||
"file:///etc/passwd",
|
||||
} {
|
||||
text, href := contactLink(bad)
|
||||
if href != "" {
|
||||
t.Errorf("contactLink(%q) produced href %q", bad, href)
|
||||
}
|
||||
if text == "" {
|
||||
t.Errorf("contactLink(%q) dropped the text entirely", bad)
|
||||
}
|
||||
|
||||
_, body := get(t, Landing("v1", true, bad, ""), "http://x/", nil)
|
||||
if strings.Contains(body, "href=\"javascript") || strings.Contains(body, "href=\"data:") {
|
||||
t.Errorf("%q reached the page as a link", bad)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestTheNoticeIsEscaped(t *testing.T) {
|
||||
_, body := get(t, Landing("v1", true, "", "<script>alert(1)</script>"), "http://x/", nil)
|
||||
if strings.Contains(body, "<script>alert(1)</script>") {
|
||||
t.Error("the notice was rendered as markup")
|
||||
}
|
||||
if !strings.Contains(body, "<script>") {
|
||||
t.Error("the notice was dropped rather than escaped")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutAContactThePageStillSaysSomethingUseful(t *testing.T) {
|
||||
_, body := get(t, Landing("v1", true, "", ""), "http://x/", nil)
|
||||
if !strings.Contains(body, "whoever operates this gateway") {
|
||||
t.Error("an unconfigured gateway leaves the reader with nothing")
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user