From 5cff456b9b98de99368bd5f1086c1f3988754a1d Mon Sep 17 00:00:00 2001 From: Ilker Manap Date: Sun, 4 Oct 2026 16:37:24 +0200 Subject: [PATCH] Let /login/oidc through without an API key: /login alone was exempt Co-Authored-By: Claude Opus 5.5 (1M context) --- internal/router/guard_test.go | 13 +++++++++++++ internal/router/handlers.go | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/internal/router/guard_test.go b/internal/router/guard_test.go index 97bdb83..12c1281 100644 --- a/internal/router/guard_test.go +++ b/internal/router/guard_test.go @@ -255,3 +255,16 @@ func TestAJudgeModelIsNotNamedToClientsInErrors(t *testing.T) { t.Errorf("named: %s", rec.Body.String()) } } + +func TestSignInThroughAProviderNeedsNoAPIKey(t *testing.T) { + e := newFakeEngine(t, "qwen2.5-14b-instruct") + rt, _ := pricedRouter(t, e.srv.URL) + rt.oidc = config.OIDC{Issuer: "http://127.0.0.1:1", ClientID: "llmgw"} + rec := httptest.NewRecorder() + rt.Handler().ServeHTTP(rec, httptest.NewRequest("GET", "/login/oidc", nil)) + // The provider is not there, so the page says so — but it is the page, + // not the API's "no key". + if rec.Code == http.StatusUnauthorized || !strings.Contains(rec.Body.String(), "sign-in service") { + t.Errorf("%d %s", rec.Code, rec.Body.String()) + } +} diff --git a/internal/router/handlers.go b/internal/router/handlers.go index f735ac5..22f4256 100644 --- a/internal/router/handlers.go +++ b/internal/router/handlers.go @@ -261,7 +261,7 @@ func (r *Router) Handler() http.Handler { // stays open because a load balancer has no key. return auth.Middleware(r.auth, r.log, "/health", "/ready", "/leader", "/", "/about", "/_static/", "/claim/", - "/signup", "/login", "/logout", "/profile", "/profile/", + "/signup", "/login", "/login/", "/logout", "/profile", "/profile/", "/scim/", "/admin", "/admin/", "/chat", "/chat/", "/org", "/org/", "/setup/")(mux) }