Asking a coding model for anything real produces a small tree, and the only way to get it out of the page was to select each block and paste it somewhere. A reply containing fenced code now offers a zip, with the directory structure the model described. Server-side, because the interesting part is the filenames. They are written by a language model and they go into an archive that somebody extracts with a tool that trusts archives, so "../../.ssh/authorized_keys" and "/etc/cron.d/x" are inputs to expect rather than hope against. archive/zip and a sanitiser with tests beat string handling in a browser. An absolute path is made relative — it cannot escape once the leading separator is gone, and refusing a file over a leading slash throws away work. Anything that still escapes after cleaning is rejected rather than repaired, because silently turning ../../evil.go into evil.go puts a file somewhere the reader did not expect; it gets a generated name instead. Naming follows what models actually do: on the fence (```go:cmd/main.go, ```main.go, ```go main.go, title="x"), or on the line above it as a heading or comment. Only the two lines immediately above, so a sentence mentioning main.go is not read as a filename. A block nobody named still comes back under a generated name, because losing code because it was unlabelled is worse than naming it badly, and two blocks claiming one path both survive — models show a file and then show it again with one line changed. Nothing is stored: the reply arrives, the zip goes back, neither is kept. The endpoint sits behind the same session guard and CSRF check as /chat/send. Two of these tests asserted the wrong thing when first written — that an absolute path must be refused, and that hyphens are stripped from the archive name. Both were corrected to what the code should do rather than the code changed to match them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
0a98d01361
commit
45d0dee470
7 files changed
+691
No files matched your search
@@ -117,6 +117,39 @@ access to it.</p>
|
||||
} catch (e) { /* a reply without maths is better than no reply */ }
|
||||
}
|
||||
|
||||
// Fetched rather than linked, because the archive is built from a POST body
|
||||
// and there is no URL that names it. The blob is revoked immediately after
|
||||
// the click: it is the whole reply, and leaving it alive keeps it addressable
|
||||
// for as long as the tab is open.
|
||||
async function downloadCode(reply, btn) {
|
||||
const was = btn.textContent;
|
||||
btn.disabled = true;
|
||||
btn.textContent = "Preparing…";
|
||||
try {
|
||||
const resp = await fetch("/chat/download", {
|
||||
method: "POST",
|
||||
headers: { "Content-Type": "application/json", "X-CSRF-Token": csrf },
|
||||
body: JSON.stringify({ content: reply, name: "code" }),
|
||||
});
|
||||
if (!resp.ok) {
|
||||
btn.textContent = "(" + resp.status + ") " + (await resp.text()).slice(0, 120);
|
||||
return;
|
||||
}
|
||||
const url = URL.createObjectURL(await resp.blob());
|
||||
const a = document.createElement("a");
|
||||
a.href = url;
|
||||
a.download = (resp.headers.get("Content-Disposition") || "")
|
||||
.match(/filename="?([^"]+)"?/)?.[1] || "code.zip";
|
||||
a.click();
|
||||
URL.revokeObjectURL(url);
|
||||
btn.textContent = was;
|
||||
} catch (err) {
|
||||
btn.textContent = "download failed";
|
||||
} finally {
|
||||
btn.disabled = false;
|
||||
}
|
||||
}
|
||||
|
||||
form.onsubmit = async (e) => {
|
||||
e.preventDefault();
|
||||
const text = input.value.trim();
|
||||
@@ -173,6 +206,18 @@ access to it.</p>
|
||||
}
|
||||
if (reply) {
|
||||
messages.push({ role: "assistant", content: reply });
|
||||
// A reply with fenced code gets a download. The button carries the
|
||||
// reply text; the server decides what the files are called, because
|
||||
// those names come from the model and sanitising them is not a job
|
||||
// for string handling in a page.
|
||||
if (/^\s*(```|~~~)/m.test(reply)) {
|
||||
const dl = document.createElement("button");
|
||||
dl.type = "button";
|
||||
dl.className = "link download";
|
||||
dl.textContent = "Download as .zip";
|
||||
dl.onclick = () => downloadCode(reply, dl);
|
||||
out.after(dl);
|
||||
}
|
||||
if (finish === "length") {
|
||||
// Appended as a sibling, never into the reply: out holds model text
|
||||
// placed with textContent, and this is ours.
|
||||
|
||||
Reference in new issue
Block a user