Fixes from the second review: grants, flags, updates, setup
CI / test (push) Successful in 9m15s

- Revoking a server's tools takes them from every level beneath too, and a
  level left naming no tool stays closed ([]) while any level above or
  beneath names tools: an organization's revoke left its teams the copies
  their first grants took, and going back to no list opened the level to
  what was above it. A closed level is shown on the page and in the
  console with an action to open it (store.OpenTools). A key's owner's
  list is among the levels above a key.
- The flag check matches short flags as written again (-m, -hf, -mu were
  let through), takes a long flag's beginning for it only for the engines
  that parse with argparse (vLLM, SGLang, ComfyUI: --li is --listen), so
  llama.cpp's own --chat-template is not refused, and refuses llama.cpp's
  short spellings (-hfr, -hff, -mm, -jf, …).
- A stored model with an adapter by Hugging Face id can be changed again:
  what it already had is not asked about anew.
- The catalog reads a Hugging Face id as the agent does (engines.IsHubID).
- The page's form cannot move llmgw:admin to another address.
- server init skips the memory check only where the gateway already runs,
  not wherever a half-finished first run left server.yaml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Ilker ManapandClaude Opus 5.5 committed 2026-10-29 12:31:07 +01:00
1 parent ecf5545a7a
commit 1948a787ae
15 files changed
+322 -44

No files matched your search

+5 -1
View File
@@ -81,7 +81,11 @@
{{end}}
</table>
{{else}}<p class="sub">{{t "mcp.none"}}</p>{{end}}
{{if .Closed}}<p class="note">{{t "mcp.closed"}} {{range $i, $c := .Closed}}{{if $i}}, {{end}}{{t (printf "mcp.scope.%s" $c.Scope)}} {{$c.Label}}{{end}}.</p>{{end}}
{{if .Closed}}<p class="note">{{t "mcp.closed"}}</p>
<ul class="mcp-closed">{{range .Closed}}<li>{{t (printf "mcp.scope.%s" .Scope)}} {{.Label}}
<form method="post" action="/admin/mcp/open" class="inline" data-confirm="{{t "mcp.confirm_open" .Label}}">
<input type="hidden" name="csrf" value="{{$.CSRF}}"><input type="hidden" name="scope" value="{{.Scope}}"><input type="hidden" name="id" value="{{.ID}}">
<button type="submit" class="link">{{t "mcp.open"}}</button></form></li>{{end}}</ul>{{end}}
<p class="sub">{{t "mcp.how_grants"}}</p>
<h2>{{t "mcp.add"}}</h2>