The admin listener has no login. Reaching it is meant to mean holding the control plane, so it binds to loopback and an operator reaches it over an ssh tunnel — and so does every page open in that operator's browser. The API decoded JSON whatever the Content-Type said, so a page could POST a text/plain model definition, no preflight needed. A model's profile env reached an engine the agent runs as root, unfiltered: LD_PRELOAD in a definition was code execution on every node. A page that rebound its own name to 127.0.0.1 could also read pprof's heap, which holds API keys. The admin listener now answers only when Host is an address or localhost, refuses requests a browser marks as cross-site (Origin, Sec-Fetch-Site), and takes changes only as application/json, which no page can send across origins without a preflight nobody grants. ctl sends that on every change, bodiless DELETEs included; curl and ctl are otherwise unaffected. Profile env that changes what runs rather than how — the dynamic loader's LD_*, PATH, Python's PYTHON* start-up variables, BASH_ENV and their like — is refused when a model is defined, and dropped again by the engine adapter before the process starts, whatever sent the profile. None of the live catalog's models sets any. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
31 lines
1.3 KiB
Go
31 lines
1.3 KiB
Go
package engines
|
|
|
|
import "strings"
|
|
|
|
// UnsafeEnv reports whether a profile may not set an environment variable,
|
|
// and why.
|
|
//
|
|
// A profile's env is the escape hatch for tuning no adapter can guess —
|
|
// CUDA_*, NCCL_*, VLLM_*, HF_* — and it reaches an engine the agent starts as
|
|
// root. Some variables are not tuning but a way to run other code in that
|
|
// process: the dynamic loader's LD_PRELOAD, Python's PYTHONSTARTUP, a shell's
|
|
// BASH_ENV. Set from a model definition, which an admin API or a config file
|
|
// supplies, they would turn "add a model" into "run this as root on every
|
|
// node". They are refused where a model is defined and again where an engine
|
|
// starts.
|
|
func UnsafeEnv(key string) (bool, string) {
|
|
k := strings.ToUpper(key)
|
|
switch {
|
|
case strings.HasPrefix(k, "LD_"), strings.HasPrefix(k, "DYLD_"):
|
|
return true, "it changes what the dynamic loader loads"
|
|
case k == "PATH":
|
|
return true, "it changes which binaries run"
|
|
case strings.HasPrefix(k, "PYTHON") && k != "PYTHONUNBUFFERED" && k != "PYTHONHASHSEED":
|
|
return true, "it changes what Python imports or runs at start"
|
|
case k == "BASH_ENV" || k == "ENV" || k == "PERL5OPT" || k == "PERL5LIB" ||
|
|
k == "NODE_OPTIONS" || k == "RUBYOPT" || k == "GCONV_PATH" || k == "OPENSSL_CONF":
|
|
return true, "it makes an interpreter or library load code"
|
|
}
|
|
return false, ""
|
|
}
|