A path is still SQLite and a postgres:// URL is PostgreSQL, so every existing configuration keeps working untouched and moving is one line changed rather than a new setting to find. An address of the form @/path/to/file reads the real one out of that file, which is how a DSN carrying a password stays out of a configuration that gets copied, diffed and pasted into issues. The driver is pgx, which is pure Go. That is not a preference: the whole binary is built with CGO_ENABLED=0 so it runs on a node whose libc is older than the builder's, and a cgo driver would take that away from every deployment, including the ones still on SQLite. Tested against a real PostgreSQL, which found two things nothing else could. The schema_migrations table is created in Go rather than in a migration file, so it escaped the port and still said INTEGER — 64 bits in SQLite, 32 in PostgreSQL, and a millisecond timestamp does not fit, so the very first migration failed to record that it had run. And the memory migration uses an FTS5 virtual table with three triggers keeping it in step, which has no counterpart: PostgreSQL derives a tsvector from the row, so there is nothing to keep in step and no trigger to forget. That leaves exactly one query that is not the same sentence in both dialects — the note search, MATCH against @@ — and it is written out twice rather than hidden behind a shared spelling that would mean something subtly different in each. Everything else is one set of queries. The text search uses the 'simple' configuration rather than English. These are an agent's own notes, in whatever language it chose, and stemming English rules over Turkish would quietly stop finding things. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
62 lines
2.0 KiB
Go
62 lines
2.0 KiB
Go
package store
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"strings"
|
|
)
|
|
|
|
// Open picks a backend from what the address looks like.
|
|
//
|
|
// A path is SQLite and a postgres:// URL is PostgreSQL, so an existing
|
|
// configuration keeps working untouched and moving to PostgreSQL is one line
|
|
// changed rather than a new setting to discover. A gateway on one machine has
|
|
// no reason to run a database server, and a gateway that has outgrown that
|
|
// should not have to be reconfigured twice.
|
|
//
|
|
// An address of the form @/path/to/file reads the real address out of that
|
|
// file, which is how a DSN carrying a password stays out of a configuration
|
|
// file that gets copied, diffed and pasted into issues.
|
|
func Open(ctx context.Context, address string) (*SQLite, error) {
|
|
address, err := resolveAddress(address)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if isPostgres(address) {
|
|
return OpenPostgres(ctx, address)
|
|
}
|
|
return OpenSQLite(ctx, address)
|
|
}
|
|
|
|
// isPostgres reports whether an address names a PostgreSQL server.
|
|
//
|
|
// By scheme, because that is the only part of a DSN that is reliably there.
|
|
// A bare host:port would be ambiguous with a relative file path, so it is not
|
|
// accepted: an address this cannot classify should fail loudly rather than
|
|
// quietly create a SQLite file named after someone's database server.
|
|
func isPostgres(address string) bool {
|
|
return strings.HasPrefix(address, "postgres://") ||
|
|
strings.HasPrefix(address, "postgresql://")
|
|
}
|
|
|
|
// resolveAddress expands an @file indirection.
|
|
//
|
|
// The file is read whole and trimmed, so a trailing newline — which every
|
|
// editor and every `echo` adds — does not become part of a password.
|
|
func resolveAddress(address string) (string, error) {
|
|
if !strings.HasPrefix(address, "@") {
|
|
return address, nil
|
|
}
|
|
path := strings.TrimPrefix(address, "@")
|
|
b, err := os.ReadFile(path)
|
|
if err != nil {
|
|
return "", fmt.Errorf("reading the store address from %s: %w", path, err)
|
|
}
|
|
out := strings.TrimSpace(string(b))
|
|
if out == "" {
|
|
return "", fmt.Errorf("%s is empty, so there is no store address in it", path)
|
|
}
|
|
return out, nil
|
|
}
|