MCP servers: fields that can be emptied, addresses without passwords
From review. A server's description, timeout and rate can be emptied from the console and the page (MCPServerRequest.Clear), where an empty field used to leave them as they were. An address with a user and password in it is refused (adminapi.CheckMCPAddress): the credential belongs in a header, sealed, and the address is shown and audited as written. The console accepts llmgw:admin and the page lets it be changed, address fixed. A grant to a key that is not there is refused rather than said done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
721705b29d
commit
f94d902cc3
5 files changed
+106
-18
No files matched your search
@@ -57,16 +57,16 @@
|
||||
<button type="submit">{{t "mcp.revoke" .Label}}</button></form>
|
||||
{{end}}{{end}}
|
||||
|
||||
{{if not .Local}}
|
||||
<h3>{{t "mcp.change"}}</h3>
|
||||
<form method="post" action="/admin/mcp/{{.Name}}/edit">
|
||||
<input type="hidden" name="csrf" value="{{$.CSRF}}">
|
||||
<label>{{t "mcp.address"}} <input type="text" inputmode="url" name="url" value="{{.URL}}" required></label>
|
||||
<label>{{t "mcp.address"}} <input type="text" inputmode="url" name="url" value="{{.URL}}" required{{if .Local}} readonly{{end}}></label>
|
||||
<label>{{t "mcp.about"}} <input type="text" name="description" value="{{.Description}}"></label>
|
||||
<label>{{t "mcp.timeout"}} <input type="number" name="timeout" min="0" value="{{if .TimeoutSeconds}}{{.TimeoutSeconds}}{{end}}"></label>
|
||||
<label>{{t "mcp.rate"}} <input type="number" name="rate" min="0" value="{{if .RatePerMinute}}{{.RatePerMinute}}{{end}}"></label>
|
||||
<button type="submit">{{t "mcp.save"}}</button>
|
||||
</form>
|
||||
{{if not .Local}}
|
||||
<h3>{{t "mcp.credential"}}</h3>
|
||||
<form method="post" action="/admin/mcp/{{.Name}}/credential">
|
||||
<input type="hidden" name="csrf" value="{{$.CSRF}}">
|
||||
|
||||
Reference in new issue
Block a user