Guard the admin API and pprof with a token only root and the server can read
The admin listener answered any local process: models added, nodes upgraded, engine keys listed, the heap dumped. /api and /debug now demand the token the server writes 0600 to its state directory on first start; ctl, the console and node add send it (sudo, LLMGW_ADMIN_TOKEN or --token-file). pprof is off unless debug_pprof. admin_listen off loopback is refused unless admin_remote. Dashboard pages, /metrics and /health are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
2d47427cdc
commit
c0421bc7ee
12 files changed
+365
-19
No files matched your search
@@ -0,0 +1,52 @@
|
||||
package cli
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
"gitea.mynodes.xyz/ilker/llmgw/internal/config"
|
||||
)
|
||||
|
||||
func TestTheAdminTokenIsMadeOnceReadableOnlyByItsOwner(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
cfgPath := filepath.Join(dir, "server.yaml")
|
||||
p := adminTokenPath(cfgPath, config.Default())
|
||||
if p != filepath.Join(dir, "secrets", "admin-token") {
|
||||
t.Fatalf("path %s", p)
|
||||
}
|
||||
tok, err := ensureAdminToken(p)
|
||||
if err != nil || len(tok) != 64 {
|
||||
t.Fatalf("%q %v", tok, err)
|
||||
}
|
||||
if st, _ := os.Stat(p); st.Mode().Perm() != 0o600 {
|
||||
t.Errorf("mode %v", st.Mode())
|
||||
}
|
||||
again, _ := ensureAdminToken(p)
|
||||
if again != tok {
|
||||
t.Error("a second start made a new token")
|
||||
}
|
||||
t.Setenv("LLMGW_ADMIN_TOKEN", "")
|
||||
if got := readAdminToken(p); got != tok {
|
||||
t.Errorf("read %q", got)
|
||||
}
|
||||
t.Setenv("LLMGW_ADMIN_TOKEN", "from-env")
|
||||
if got := readAdminToken(p); got != "from-env" {
|
||||
t.Errorf("env: %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestTheAdminListenerStaysOnLoopbackUnlessToldOtherwise(t *testing.T) {
|
||||
cfg := config.Default()
|
||||
for addr, ok := range map[string]bool{"127.0.0.1:9090": true, "localhost:9090": true, "[::1]:9090": true,
|
||||
"0.0.0.0:9090": false, ":9090": false, "10.0.0.140:9090": false} {
|
||||
cfg.AdminListen = addr
|
||||
if err := checkAdminListen(cfg); (err == nil) != ok {
|
||||
t.Errorf("%s: %v", addr, err)
|
||||
}
|
||||
}
|
||||
cfg.AdminListen, cfg.AdminRemote = "10.0.0.140:9090", true
|
||||
if err := checkAdminListen(cfg); err != nil {
|
||||
t.Errorf("admin_remote: %v", err)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user