Carry a download's progress to where somebody is looking at it
The agent has always logged a percentage as it fetches weights, with a comment saying a replica pulling a hundred gigabytes and one that is wedged look identical from the control plane. They still did: the log is on the node, and the node is not where anyone is looking when a replica has been starting for ten minutes. Progress now rides on the shard status and appears under the replica in `ctl replicas` — a line rather than a column, because most replicas are not downloading anything and a column would be empty for all of them. It is deliberately not a state transition. Treating each chunk as one would re-mark the shard as starting on every report and reset the timer that decides when a slow start has become a failed one, so an hour-long download would keep a doomed replica alive indefinitely. It arrives on its own method for that reason, and a real transition clears it — otherwise a finished download sits in the listing at ninety-nine percent under a shard that has been serving for an hour. Watchers are keyed by source rather than by shard, because a fetch is single-flight: eight shards starting together produce one download and all eight are waiting on it. No percentage is invented when the server sent no length. One that stops moving is worse than a byte count that keeps rising, so the field is absent and the listing says "so far". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
100f10ac17
commit
a35e8796d2
11 files changed
+447
-60
No files matched your search
@@ -3,6 +3,7 @@ package cli
|
||||
import (
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"strings"
|
||||
|
||||
"github.com/spf13/cobra"
|
||||
|
||||
@@ -151,3 +152,23 @@ func fileSize(b int64) string {
|
||||
return "size unknown"
|
||||
}
|
||||
}
|
||||
|
||||
// fetchColumn renders a download's progress.
|
||||
//
|
||||
// A percentage when the size is known and a byte count when it is not, because
|
||||
// a server that does not send Content-Length is common enough — and an
|
||||
// invented percentage that stops moving is worse than a number that rises.
|
||||
func fetchColumn(f *adminapi.FetchView) string {
|
||||
if f.Percent != nil {
|
||||
return fmt.Sprintf("%s %d%% of %s", shortSource(f.Source), *f.Percent, fileSize(f.BytesTotal))
|
||||
}
|
||||
return fmt.Sprintf("%s %s so far", shortSource(f.Source), fileSize(f.BytesDone))
|
||||
}
|
||||
|
||||
// shortSource keeps the end of a source, which is the part that identifies it.
|
||||
func shortSource(s string) string {
|
||||
if i := strings.LastIndex(s, "/"); i >= 0 && i < len(s)-1 {
|
||||
return s[i+1:]
|
||||
}
|
||||
return s
|
||||
}
|
||||
Reference in new issue
Block a user