Revoke a removed node's certificate, and require --api-client with a mirror's mutual TLS
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
fe5b7f88f0
commit
9b61bbc983
16 files changed
+268
-32
No files matched your search
@@ -7,6 +7,7 @@ import (
|
||||
"log/slog"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"slices"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
@@ -707,3 +708,30 @@ func TestOnlyANodeThatIsGoneCanBeRemoved(t *testing.T) {
|
||||
t.Errorf("removing it again gave %d, expected 404", code)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRemovingANodeRevokesItsCertificate(t *testing.T) {
|
||||
a, ctl := setup(t, testModels(), gpuNode("n1", 8), gpuNode("n2", 8))
|
||||
var revoked []string
|
||||
a.SetRevoker(func(_ context.Context, id string, _ time.Time) error {
|
||||
revoked = append(revoked, id)
|
||||
return nil
|
||||
})
|
||||
ctl.Inventory().SetState("n1", inventory.Lost)
|
||||
if code := call(t, a, "DELETE", "/api/v1/nodes/n1", "", nil); code != 200 {
|
||||
t.Fatalf("a lost node gave %d, expected 200", code)
|
||||
}
|
||||
if !slices.Equal(revoked, []string{"n1"}) {
|
||||
t.Errorf("revoked %v, expected n1", revoked)
|
||||
}
|
||||
|
||||
// Not revoked, not removed: a node left listed is one the operator can
|
||||
// see and try again on.
|
||||
a.SetRevoker(func(context.Context, string, time.Time) error { return errors.New("store down") })
|
||||
ctl.Inventory().SetState("n2", inventory.Lost)
|
||||
if code := call(t, a, "DELETE", "/api/v1/nodes/n2", "", nil); code != 500 {
|
||||
t.Errorf("a failed revocation gave %d, expected 500", code)
|
||||
}
|
||||
if _, ok := ctl.Inventory().Get("n2"); !ok {
|
||||
t.Error("the node was removed though its certificate was not revoked")
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user