Let people change their own password, and operators reset a lost one
The account system shipped without either, which made the first forgotten password an unanswerable support request. Changing it requires the current one. A session is what an attacker gets from a borrowed laptop or a stolen cookie; the password is what they do not have, and without the check the first thing they would do is take the account. Every session is closed, including the browser doing the changing — leaving the others open would mean a password change does nothing about the reason someone is changing it. A new session is then opened for the browser in front of us, so the person who just proved their password is not thrown back to the sign-in page. That response also carries a new CSRF cookie, so the forms it renders take the new token rather than the one the request arrived with; there is a test that posts a form from that exact page. Guessing the current password is bounded the same way sign-in is, because someone holding a stolen session should not get unlimited attempts at the password that would let them keep it. There is no self-service reset: this gateway sends no email, and a reset link with nowhere to send it is not a reset. `llmgw users reset-password` is the operator's answer, and it closes their sessions too — if someone lost their password, the reason might be that somebody else has it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
216fc9bb03
commit
79e459d9ff
10 files changed
+437
-24
No files matched your search
@@ -197,3 +197,21 @@ func (s *SQLite) scanUser(sc scanner) (User, error) {
|
||||
u.LastLoginAt = fromNullMillis(lastLogin)
|
||||
return u, nil
|
||||
}
|
||||
|
||||
// SetPassword replaces an account's password hash.
|
||||
//
|
||||
// It does not close sessions; that is the caller's decision, because the two
|
||||
// reasons to change a password want different things. Someone rotating theirs
|
||||
// wants their other devices signed out. An operator resetting a forgotten one
|
||||
// wants the same, but also has nobody to keep signed in.
|
||||
func (s *SQLite) SetPassword(ctx context.Context, userID, hash string) error {
|
||||
res, err := s.db.ExecContext(ctx, `UPDATE users SET password_hash = ? WHERE id = ?`,
|
||||
hash, userID)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if n, _ := res.RowsAffected(); n == 0 {
|
||||
return ErrNotFound
|
||||
}
|
||||
return nil
|
||||
}
|
||||
Reference in new issue
Block a user